Throw on non-ok server responses #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 54 +1
Lines 354 356 +2
Branches 24 23 -1
=========================================
+ Hits 354 356 +2
☔ View full report in Codecov by Sentry. |
meisekimiu
approved these changes
Aug 21, 2023
When the server responds with a non-ok status we want to communicate that response to the calling code base via a thrown error. Prior to this commit server errors would often be completely ignored and could result in odd validation errors instead of communicating the actual issue. As part of this change our delete functions now *throw* when something goes wrong, and so the type signature has been updated to no longer return `boolean` to indicate success but rather a `void`. Issue #59 Handle server errors explicitly Issue #89 Evalauate return types for operation methods
slifty
force-pushed
the
89-update-return-types
branch
from
a51400b
to
f130b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to throw an error in the event of a non-OK http response from the server. This also results in updated signatures for the
deletemethods, which used to return true / false depending on the outcome of a call.Resolves #59
Resolves #89